Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in testkomodo #8844

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Oct 2, 2024

Mismatched the variable names in teskomodo.sh earlier leading to exit codes not working properly at all. This pr fixes it and also adds shellcheck for ci/testkomodo.sh.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj force-pushed the fix_typos_in_testkomodo branch from 137009e to 4638d4d Compare October 2, 2024 08:27
@larsevj larsevj added the release-notes:skip If there should be no mention of this in release notes label Oct 2, 2024
@larsevj larsevj marked this pull request as ready for review October 2, 2024 08:30
@larsevj larsevj requested a review from eivindjahren October 2, 2024 08:32
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.39%. Comparing base (9f8d73a) to head (8ae6597).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8844      +/-   ##
==========================================
+ Coverage   91.37%   91.39%   +0.02%     
==========================================
  Files         342      343       +1     
  Lines       21028    21069      +41     
==========================================
+ Hits        19215    19257      +42     
+ Misses       1813     1812       -1     
Flag Coverage Δ
cli-tests 39.64% <ø> (+0.04%) ⬆️
gui-tests 73.55% <ø> (-0.03%) ⬇️
performance-tests 50.19% <ø> (+0.13%) ⬆️
unit-tests 79.86% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larsevj larsevj force-pushed the fix_typos_in_testkomodo branch 3 times, most recently from a79f329 to 8ae6597 Compare October 2, 2024 09:07
@larsevj larsevj merged commit ad8bfc4 into equinor:main Oct 2, 2024
50 checks passed
@larsevj larsevj deleted the fix_typos_in_testkomodo branch October 2, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants