-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use wait_for_child for getting RunDialog #8839
Use wait_for_child for getting RunDialog #8839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not solve flakyness, but valid as refactor.
Indeed, even failed on that commit, trying with increased timeout. |
b6ac7e4
to
4c990a3
Compare
4c990a3
to
a5216de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏🏻
Nope, times out also for 10s. |
6412c5f
to
38afca8
Compare
38afca8
to
02f0ae4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8839 +/- ##
==========================================
+ Coverage 91.37% 91.39% +0.01%
==========================================
Files 342 342
Lines 21028 21028
==========================================
+ Hits 19215 19218 +3
+ Misses 1813 1810 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Issue
Simplifies for #8838
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable