Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wait_for_child for getting RunDialog #8839

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Oct 1, 2024

Issue
Simplifies for #8838

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:skip If there should be no mention of this in release notes label Oct 1, 2024
@eivindjahren eivindjahren enabled auto-merge (rebase) October 1, 2024 12:55
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not solve flakyness, but valid as refactor.

@eivindjahren
Copy link
Contributor Author

Does not solve flakyness, but valid as refactor.

Indeed, even failed on that commit, trying with increased timeout.

@eivindjahren eivindjahren force-pushed the mitigate_getting_rundialog branch from b6ac7e4 to 4c990a3 Compare October 1, 2024 13:14
@eivindjahren eivindjahren force-pushed the mitigate_getting_rundialog branch from 4c990a3 to a5216de Compare October 1, 2024 13:22
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

@eivindjahren
Copy link
Contributor Author

Nope, times out also for 10s.

@eivindjahren eivindjahren force-pushed the mitigate_getting_rundialog branch from 6412c5f to 38afca8 Compare October 1, 2024 14:39
@eivindjahren eivindjahren force-pushed the mitigate_getting_rundialog branch from 38afca8 to 02f0ae4 Compare October 1, 2024 14:40
@eivindjahren eivindjahren merged commit 21bbca8 into equinor:main Oct 2, 2024
50 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.39%. Comparing base (9f8d73a) to head (02f0ae4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8839      +/-   ##
==========================================
+ Coverage   91.37%   91.39%   +0.01%     
==========================================
  Files         342      342              
  Lines       21028    21028              
==========================================
+ Hits        19215    19218       +3     
+ Misses       1813     1810       -3     
Flag Coverage Δ
cli-tests 39.61% <ø> (+<0.01%) ⬆️
gui-tests 73.58% <ø> (ø)
performance-tests 50.05% <ø> (ø)
unit-tests 79.83% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants