Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused directory #8836

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Remove unused directory #8836

merged 1 commit into from
Oct 5, 2024

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Oct 1, 2024

Drive by cleaning

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide self-assigned this Oct 1, 2024
@oyvindeide oyvindeide added the release-notes:skip If there should be no mention of this in release notes label Oct 1, 2024
Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🧹

@DanSava
Copy link
Contributor

DanSava commented Oct 2, 2024

There seems to be some flakiness in the tests. The failing tests seem to have already been reported.

@eivindjahren eivindjahren changed the title Remove unused folder Remove unused directory Oct 3, 2024
@oyvindeide oyvindeide enabled auto-merge (rebase) October 5, 2024 17:49
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.42%. Comparing base (8fef8f4) to head (61c039b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8836      +/-   ##
==========================================
- Coverage   91.42%   91.42%   -0.01%     
==========================================
  Files         344      344              
  Lines       21120    21120              
==========================================
- Hits        19309    19308       -1     
- Misses       1811     1812       +1     
Flag Coverage Δ
cli-tests 39.59% <ø> (ø)
gui-tests 73.47% <ø> (-0.03%) ⬇️
performance-tests 50.14% <ø> (-0.03%) ⬇️
unit-tests 80.08% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oyvindeide oyvindeide merged commit 793d635 into equinor:main Oct 5, 2024
56 checks passed
@oyvindeide oyvindeide deleted the remove_unsed branch October 5, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants