Turn unexpected fm errors into warnings #8832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
reviewed
Oct 1, 2024
src/ert/config/ert_config.py
Outdated
| @@ -608,6 +608,11 @@ def _create_list_of_forward_model_steps_to_run( | |||
| context=fm_step.name, | |||
| ), | |||
| ) | |||
| except Exception as e: # type: ignore | |||
| ConfigWarning.warn(str(e), context=fm_step.name) | |||
There was a problem hiding this comment.
I think both the log and the warning should have the text Unexpected exception in forward model validation of {fm_step.name}: as all ConfigWarnings are logged in the Suggestor we don't need an additional log statement.
eivindjahren
requested changes
Oct 1, 2024
yngve-sk
force-pushed
the
fmplugin-othererrsaswarns
branch
from
8e8c117 to
2b21053
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8832 +/- ##
==========================================
+ Coverage 91.38% 91.41% +0.02%
==========================================
Files 342 342
Lines 21028 21030 +2
==========================================
+ Hits 19216 19224 +8
+ Misses 1812 1806 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #8830