Log LSF execution host to Azure #8826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreas-el
force-pushed
the
propagate_exec_host_to_azure_logs
branch
from
461aaff to
1f5f5d5
Compare
andreas-el
added
enhancement
release-notes:improvement
andreas-el
changed the title
andreas-el
force-pushed
the
propagate_exec_host_to_azure_logs
branch
from
08f19db to
fd4dab2
Compare
Retrieve exec_hosts from bjobs and log to azure Update bjobs output with placeholder for exec_hosts in tests Add tests for bjobs_exec_host parsing
andreas-el
force-pushed
the
propagate_exec_host_to_azure_logs
branch
from
fd4dab2 to
473854b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8826 +/- ##
==========================================
+ Coverage 91.30% 91.40% +0.09%
==========================================
Files 342 343 +1
Lines 21028 21084 +56
==========================================
+ Hits 19200 19272 +72
+ Misses 1828 1812 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
berland
reviewed
Oct 1, 2024
berland
reviewed
Oct 1, 2024
|
Is there a test to assert that this message is only logged once pr realization? |
eivindjahren
reviewed
Oct 1, 2024
src/ert/scheduler/lsf_driver.py
Outdated
| bjobs_exec_hosts = parse_bjobs_exec_hosts(stdout.decode(errors="ignore")) | ||
|
|
||
| for jobid, exec_hosts in bjobs_exec_hosts.items(): | ||
| if self._jobs[jobid].exec_hosts == "-": |
There was a problem hiding this comment.
This condition is never true in the tests.
There was a problem hiding this comment.
I rewrote this to get better coverage. Also, this is the default value for exec_hosts, and the value bjobs will yield when no node is yet assigned for the job.
A re-run of codecov would have been nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves https://github.com/equinor/scout/issues/1117
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable