Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wait_for_child for getting RunDialog in test #8823

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Sep 30, 2024

Quick cleanup of comment and fetching of RunDialog in test_restart_ensemble

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@eivindjahren eivindjahren enabled auto-merge (rebase) September 30, 2024 11:56
@eivindjahren eivindjahren merged commit ca33dca into equinor:main Sep 30, 2024
50 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.38%. Comparing base (e607feb) to head (bb7f4be).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8823      +/-   ##
==========================================
+ Coverage   91.31%   91.38%   +0.06%     
==========================================
  Files         342      342              
  Lines       21028    21028              
==========================================
+ Hits        19202    19216      +14     
+ Misses       1826     1812      -14     
Flag Coverage Δ
cli-tests 39.62% <ø> (-0.02%) ⬇️
gui-tests 73.58% <ø> (+0.12%) ⬆️
performance-tests 50.05% <ø> (ø)
unit-tests 79.82% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants