Ensure keys can contain "/" #8818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindjahren
force-pushed
the
stateful_dark_storage_test
branch
4 times, most recently
from
5bcc770 to
e913fdb
Compare
eivindjahren
force-pushed
the
stateful_dark_storage_test
branch
9 times, most recently
from
daffeed to
6d9750d
Compare
eivindjahren
force-pushed
the
stateful_dark_storage_test
branch
from
41e2574 to
84948e6
Compare
eivindjahren
force-pushed
the
stateful_dark_storage_test
branch
from
84948e6 to
a9bc2ed
Compare
eivindjahren
added
the
release-notes:bug-fix
eivindjahren
force-pushed
the
stateful_dark_storage_test
branch
from
a9bc2ed to
a58610d
Compare
eivindjahren
force-pushed
the
stateful_dark_storage_test
branch
from
a58610d to
e5934eb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8818 +/- ##
==========================================
+ Coverage 91.67% 91.70% +0.03%
==========================================
Files 343 343
Lines 21153 21243 +90
==========================================
+ Hits 19392 19481 +89
- Misses 1761 1762 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eivindjahren
force-pushed
the
stateful_dark_storage_test
branch
from
94ee1ae to
7d8d5df
Compare
andreas-el
reviewed
Oct 11, 2024
| @rule(model_ensemble=StatefulStorageTest.ensembles, data=st.data()) | ||
| def get_response_csv_through_client(self, model_ensemble, data): | ||
| assume(model_ensemble.response_values) | ||
| print(model_ensemble.response_values) |
andreas-el
reviewed
Oct 11, 2024
| self.client.get("/updates/storage") | ||
| response = self.client.get("/experiments") | ||
| experiment_records = response.json() | ||
| assert len(experiment_records) == len(list(self.storage.experiments)) |
There was a problem hiding this comment.
Can we check that this is not zero also?
There was a problem hiding this comment.
It could be empty if we haven't initialized anything in storage yet.
eivindjahren
force-pushed
the
stateful_dark_storage_test
branch
from
7d8d5df to
d1363a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #8716
Resolves #8944
Need to make the following change to webviz-ert: equinor/webviz-ert#475
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable