Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use iens = 0 to avoid error with ensemble_size=1 #8817

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

eivindjahren
Copy link
Contributor

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.36%. Comparing base (321767c) to head (a03d62c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8817      +/-   ##
==========================================
- Coverage   91.36%   91.36%   -0.01%     
==========================================
  Files         342      342              
  Lines       20995    20995              
==========================================
- Hits        19183    19182       -1     
- Misses       1812     1813       +1     
Flag Coverage Δ
cli-tests 39.62% <ø> (+<0.01%) ⬆️
gui-tests 73.53% <ø> (+0.02%) ⬆️
performance-tests 50.08% <ø> (ø)
unit-tests 79.83% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eivindjahren eivindjahren merged commit 30dba51 into equinor:main Sep 27, 2024
50 checks passed
@eivindjahren eivindjahren deleted the fix_stateful_storage_test branch September 27, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants