Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky memory test #8812

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Fix flaky memory test #8812

merged 1 commit into from
Sep 27, 2024

Conversation

JHolba
Copy link
Contributor

@JHolba JHolba commented Sep 27, 2024

Register only the memory allocations of the function we are trying to test.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Register only the memory allocations of the function we are trying to
test.
@JHolba JHolba self-assigned this Sep 27, 2024
@JHolba JHolba added the release-notes:skip If there should be no mention of this in release notes label Sep 27, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.37%. Comparing base (53fe7c0) to head (c0d51b3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8812      +/-   ##
==========================================
+ Coverage   91.31%   91.37%   +0.05%     
==========================================
  Files         342      342              
  Lines       20985    20995      +10     
==========================================
+ Hits        19163    19184      +21     
+ Misses       1822     1811      -11     
Flag Coverage Δ
cli-tests 39.60% <ø> (+0.02%) ⬆️
gui-tests 73.53% <ø> (+0.04%) ⬆️
performance-tests 50.07% <ø> (+<0.01%) ⬆️
unit-tests 79.85% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eivindjahren eivindjahren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JHolba JHolba merged commit 3bc3a88 into equinor:main Sep 27, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants