Remove Everest restart functionality #8809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verveerpj
added
payback
release-notes:user-impact
verveerpj
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #8809 +/- ##
=======================================
Coverage 91.36% 91.37%
=======================================
Files 342 342
Lines 20995 20995
=======================================
+ Hits 19183 19184 +1
+ Misses 1812 1811 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
verveerpj
force-pushed
the
everest-remove-restart
branch
from
02091d4 to
bba48bc
Compare
The restart functionality was added to support a research project. However it turned out to be unnecessary for that project. Since functionality should not be added for such a purpose only and the general usefulness of the feature is unclear it should be removed.
verveerpj
force-pushed
the
everest-remove-restart
branch
from
bba48bc to
12b6829
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The restart functionality was original added to support a research project. It turned out to be unnecessary. Since features should not be added for such a purpose and it is not clear if the feature is useful in this form, it should be removed. To my knowledge it is unused and removal will have no impact on users, but should still be categorized as such in the release notes.
Approach
Update the documentation generator, which was broken
Remove the restart functionality from the configuration and the code
Remove the related tests
Rewrite and rename a test that was using the functionality
PR title captures the intent of the changes, and is fitting for release notes.
Added appropriate release note label
Commit history is consistent and clean, in line with the contribution guidelines.
Make sure unit tests pass locally after every commit (
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable