Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update everest dependencies on ropt #8808

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Update everest dependencies on ropt #8808

merged 1 commit into from
Sep 27, 2024

Conversation

verveerpj
Copy link
Contributor

@verveerpj verveerpj commented Sep 27, 2024

Issue
Everest depends on ropt >= 0.7

Approach
Update the dependencies

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@verveerpj verveerpj self-assigned this Sep 27, 2024
@verveerpj verveerpj added the release-notes:dependency Automatically categorise as dependency change in release notes label Sep 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (53fe7c0) to head (d40a4d2).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8808      +/-   ##
==========================================
+ Coverage   91.31%   91.33%   +0.01%     
==========================================
  Files         342      342              
  Lines       20985    20985              
==========================================
+ Hits        19163    19167       +4     
+ Misses       1822     1818       -4     
Flag Coverage Δ
cli-tests 39.57% <ø> (ø)
gui-tests 73.52% <ø> (+0.02%) ⬆️
performance-tests 50.06% <ø> (ø)
unit-tests 79.81% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@verveerpj verveerpj merged commit 7843b2f into main Sep 27, 2024
51 checks passed
@verveerpj verveerpj deleted the update-everest-deps branch September 27, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
everest release-notes:dependency Automatically categorise as dependency change in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants