Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky kill_before_submit test for lsf #8807

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix flaky kill_before_submit test for lsf #8807

merged 1 commit into from
Sep 30, 2024

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Sep 26, 2024 •
edited
Loading

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:skip If there should be no mention of this in release notes label Sep 26, 2024
berland
berland reviewed Sep 26, 2024
View reviewed changes
tests/ert/unit_tests/scheduler/test_lsf_driver.py Outdated
encoding="utf-8",
)
job_path.chmod(job_path.stat().st_mode | stat.S_IEXEC)

# Allow submit and kill to be interleaved by asyncio by issuing
# submit() in its own asyncio Task:
asyncio.create_task(
driver.submit(
# The sleep is the time window in which we can kill the job before
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment on sleep is now irrelevant.

@eivindjahren eivindjahren force-pushed the fix_flaky_test_kill_before_submit_is_finished branch from dfd04fe to f0ed313 Compare September 27, 2024 11:12
@berland
Copy link
Contributor

berland commented Sep 27, 2024

Has this been tested "live" on real compute clusters?

@eivindjahren
Copy link
Contributor Author

Has this been tested "live" on real compute clusters?

Not yet :D. I'll try it.

@eivindjahren
Copy link
Contributor Author

@berland Just checked and it worked to run this on tgx.

@eivindjahren eivindjahren force-pushed the fix_flaky_test_kill_before_submit_is_finished branch 2 times, most recently from ccc2012 to 29ae1e6 Compare September 30, 2024 12:11
berland
berland approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets roll! 🛼

@eivindjahren eivindjahren force-pushed the fix_flaky_test_kill_before_submit_is_finished branch from 29ae1e6 to bbd929a Compare September 30, 2024 12:22
@eivindjahren
Copy link
Contributor Author

@berland Seems like there is actually something wrong with the slurm driver:

https://github.com/equinor/ert/actions/runs/11105990094/job/30853371751?pr=8807#step:8:141

The logs seem to indicate that the realization is marked as successful even though it is killed.

@eivindjahren eivindjahren force-pushed the fix_flaky_test_kill_before_submit_is_finished branch 2 times, most recently from 43c2bf4 to 6089acb Compare September 30, 2024 12:38
@eivindjahren eivindjahren force-pushed the fix_flaky_test_kill_before_submit_is_finished branch from 6089acb to 2b9c6d3 Compare September 30, 2024 12:48
@eivindjahren eivindjahren changed the title Fix flaky kill_before_submit tests Fix flaky kill_before_submit test for lsf Sep 30, 2024
@eivindjahren eivindjahren enabled auto-merge (squash) September 30, 2024 12:56
@eivindjahren eivindjahren merged commit 0825322 into equinor:main Sep 30, 2024
50 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.37%. Comparing base (e607feb) to head (2b9c6d3).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8807      +/-   ##
==========================================
+ Coverage   91.31%   91.37%   +0.05%     
==========================================
  Files         342      342              
  Lines       21028    21028              
==========================================
+ Hits        19202    19214      +12     
+ Misses       1826     1814      -12
Flag Coverage Δ
cli-tests 39.59% <ø> (-0.05%) ⬇️
gui-tests 73.58% <ø> (+0.12%) ⬆️
performance-tests 50.07% <ø> (+0.01%) ⬆️
unit-tests 79.82% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berland berland berland approved these changes

Assignees
No one assigned
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eivindjahren @berland @codecov-commenter