Fix an issue where aborted processes could corrupt storage #8802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8802 +/- ##
==========================================
+ Coverage 91.29% 91.31% +0.01%
==========================================
Files 342 342
Lines 20985 20995 +10
==========================================
+ Hits 19159 19171 +12
+ Misses 1826 1824 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eivindjahren
force-pushed
the
transactional_write
branch
2 times, most recently
from
a6921a5 to
181d077
Compare
eivindjahren
force-pushed
the
transactional_write
branch
from
181d077 to
1573d77
Compare
eivindjahren
force-pushed
the
transactional_write
branch
from
1573d77 to
f7778f0
Compare
eivindjahren
changed the title
eivindjahren
added
the
release-notes:bug-fix
berland
reviewed
Sep 26, 2024
| filepath = Path("./file.txt") | ||
| storage._write_transaction(filepath, data) | ||
|
|
||
| assert filepath.read_bytes() == data |
There was a problem hiding this comment.
deindent one level to make sure the context manager does not delete it (which I assume it is not meant to do)?
There was a problem hiding this comment.
ah, that context manager is probably irrelevant to _write_transaction.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #8799
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')When applicable