Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark all flaky tests as integration_tests #8795

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Sep 25, 2024

Make sure running unit tests is reliable.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren force-pushed the mark_all_flaky_tests_as_integration_tests branch from fae2037 to a480d40 Compare September 25, 2024 07:52
@eivindjahren eivindjahren enabled auto-merge (squash) September 25, 2024 08:07
@eivindjahren eivindjahren added the release-notes:skip If there should be no mention of this in release notes label Sep 25, 2024
@eivindjahren eivindjahren merged commit 5731434 into equinor:main Sep 25, 2024
50 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (21af329) to head (a480d40).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8795      +/-   ##
==========================================
- Coverage   91.35%   91.29%   -0.07%     
==========================================
  Files         342      342              
  Lines       20982    20982              
==========================================
- Hits        19169    19155      -14     
- Misses       1813     1827      +14     
Flag Coverage Δ
cli-tests 39.51% <ø> (-0.05%) ⬇️
gui-tests 73.48% <ø> (ø)
performance-tests 50.06% <ø> (+0.01%) ⬆️
unit-tests 79.81% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants