Fix SPE1 yaml config for smry_keys #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berland
added
bug
maintenance
sondreso
force-pushed
the
fix_spe1_smry_keys
branch
from
bf2e255 to
b469ad1
Compare
berland
commented
Jan 11, 2022
berland
commented
Jan 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #2685 +/- ##
==========================================
- Coverage 65.05% 65.05% -0.01%
==========================================
Files 651 651
Lines 53917 53911 -6
Branches 4610 4610
==========================================
- Hits 35077 35072 -5
Misses 17360 17360
+ Partials 1480 1479 -1
Continue to review full report at Codecov.
|
berland
force-pushed
the
fix_spe1_smry_keys
branch
from
8cae3b2 to
3ed064d
Compare
1 task
SPE1 did not work, and this was uncaught by CI. This commit fixes * Non-zero exit code, and associated test adjustment. * Fix SPE1 yaml configuration to follow up changes in Eclsum handling. * Remove redundant summary2json in SPE1 * Fix in storage to allow transmitting RecordTrees to storage, userdata is only included when real_id=0 Co-authored-by: Håvard Berland <[email protected]> Co-authored-by: Julius Parulek <[email protected]>
berland
force-pushed
the
fix_spe1_smry_keys
branch
from
8771aa1 to
b62a7d8
Compare
sondreso
removed
the
maintenance
xjules
force-pushed
the
fix_spe1_smry_keys
branch
from
1feeb7b to
b62a7d8
Compare
xjules
approved these changes
Jan 12, 2022
sondreso
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #2684
Resolves #2683
Approach
Following up syntax change in #2613
Pre review checklist
.
Adding labels helps the maintainers when writing release notes, see sections and the
corresponding labels here: https://github.com/equinor/ert/blob/main/.github/release.yml