Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Rewrite and move breadcrumbs #2604 #2605

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

millianapia
Copy link
Contributor

No description provided.

@millianapia millianapia requested a review from a team as a code owner October 25, 2024 11:41
@millianapia millianapia self-assigned this Oct 25, 2024

export type BreadcrumbsProps = HTMLAttributes<HTMLOListElement>

export const BreadcrumbsList = forwardRef<HTMLDivElement, BreadcrumbsProps>(function Breadcrumbs(
Copy link
Contributor

@BorghildSelle BorghildSelle Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this forward return HTMLOListElement?

Copy link
Contributor

@BorghildSelle BorghildSelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants