fix: delta profile when 2 result sets have different periods #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisolba1
approved these changes
Dec 18, 2024
TeeeJay
force-pushed
the
bugfix/298_compare_fails_on_different_start_dates
branch
2 times, most recently
from
5617790 to
d13ee3d
Compare
due to opposite check of what it was supposed to, ie. check that we only include periods that are given in the common period vector, but instead there was a check that the separate result had a period that was not in the common period vector. Resolves equinor/ecalc-internal#298
TeeeJay
force-pushed
the
bugfix/298_compare_fails_on_different_start_dates
branch
from
d13ee3d to
ba1785c
Compare
jsolaas
approved these changes
Dec 18, 2024
TeeeJay
deleted the
bugfix/298_compare_fails_on_different_start_dates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to opposite check of what it was supposed to, ie. check that
we only include periods that are given in the common period vector,
but instead there was a check that the separate result had a
period that was not in the common period vector.
Resolves equinor/ecalc-internal#298