Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move to energy components #737

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

frodehk
Copy link
Contributor

@frodehk frodehk commented Dec 13, 2024

Why is this pull request needed?

Refactor parts of core to allow for improved and more flexible validation, removing dtos, avoid circular imports, remove/merge duplicate classes. The dto layer should be kept, but pydantic validation should be removed.

What does this pull request change?

  • Move energy components (e.g. FuelConsumer, ElectricityConsumer) from components.py (dto) to domain/infrastructure/energy_components.
  • Remove components.py

Issues related to this change:

@frodehk frodehk self-assigned this Dec 13, 2024
@frodehk frodehk requested a review from a team as a code owner December 13, 2024 12:25
Copy link
Collaborator

@TeeeJay TeeeJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, but see if you next time is able to keep git history, e.g. that most of the code is detected as a move, and not delete and create. E.g. move first, stage the changes so that git sees that, and then make changes/refactor, if possible :)

@frodehk frodehk force-pushed the refactor-domain-infrastructure branch from 2556cb1 to 720afad Compare December 16, 2024 12:02
@frodehk frodehk merged commit f9cf0da into main Dec 16, 2024
8 checks passed
@frodehk frodehk deleted the refactor-domain-infrastructure branch December 16, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants