create turbine builder and update turbine factory #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeeeJay
reviewed
Dec 3, 2024
| return ( | ||
| YamlTurbineBuilder() | ||
| .with_name("compressor_train_turbine") | ||
| .with_turbine_loads([0, 2.352, 4.589, 6.853, 9.125, 11.399, 13.673, 15.947, 18.223, 20.496, 22.767]) |
There was a problem hiding this comment.
should loads and efficiencies be "merged" or does it make sense to provide them independently, to be able to use different setups? also, in this case as far as I can see, you use the same parameters as with the with_test_data method, use that instead ?
There was a problem hiding this comment.
You are right, with_test_data could be used instead. I think it is more flexible to provide them independently. However, a "merged" method could also be considered in addition.
TeeeJay
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed?
Part of replacing dtos with builders in tests.
What does this pull request change?