fix: expression type in system v2 #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsolaas
commented
Sep 11, 2023
| @@ -204,7 +205,8 @@ def to_dto( | |||
| else: | |||
| rates = [ | |||
| Expression.multiply( | |||
| Expression.setup_from_expression(self.rate), Expression.setup_from_expression(rate_fraction) | |||
| Expression.setup_from_expression(operational_setting.total_system_rate), | |||
There was a problem hiding this comment.
oops, forgot to mention I fixed a bug
There was a problem hiding this comment.
nice to catch this..another "pros" of having a type/alias rather than typing the Union etc all the time...
There was a problem hiding this comment.
Ideally separate commit though...
TeeeJay
reviewed
Sep 11, 2023
| @@ -21,7 +22,7 @@ def to_dto(self, **kwargs): | |||
|
|
|||
|
|
|||
| class OperationalConditionBase(YamlBase): | |||
| condition: Optional[str] = Field( | |||
TeeeJay
approved these changes
Sep 11, 2023
jsolaas
force-pushed
the
fix/expression-json-schema
branch
from
3c7cb50 to
89de208
Compare
jsolaas
force-pushed
the
fix/expression-json-schema
branch
from
89de208 to
1de9df3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed?
Only str was allowed for expressions in the yaml models for system v2 (yellow mark because of json-schema)
What does this pull request change?
Sets the type of expression to a union of int, float and str
Issues related to this change: