wip refactoring closedloopidentifier

equinor · Dec 6, 2024 · 9a2388e · 9a2388e
1 parent 21fdded
commit 9a2388e
Show file tree

Hide file tree

Showing 4 changed files with 236 additions and 48 deletions.
diff --git a/Dynamic/Identification/ClosedLoopGainGlobalSearchResults.cs b/Dynamic/Identification/ClosedLoopGainGlobalSearchResults.cs
@@ -143,12 +143,16 @@ double[] Scale(double[] v_in)
             // as a "tiebreaker"
 
             if (v1_Strength == 0 && v2_Strength == 0 && v3_Strength == 0)
-            {/*
+            {
+                // quite frequently the algorithm arrives here, where all the three "strengths" are zero. 
+                // if there is a persistent disturbance like a randomwalk or sinus
+
+                // only thing is that in randowmalk case, this tend to over-estimate gain consistently by about 10-40%
                 if (v4_Strength > 0)
                 {
                     return  new Tuple<UnitModel, bool>(new UnitModel(unitParametersList.ElementAt(min_ind_v4)), true);
                 }
-                else*/
+                else
                 {
                     return new Tuple<UnitModel, bool>(null, false);
                 }