Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graphical format example file #48

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Conversation

NoraKri
Copy link
Contributor

@NoraKri NoraKri commented Dec 3, 2024

AB#203007

Aim of the PR

A format for data to the frontend needs to be decided on. This format should include everything needed to render the P&ID in the frontend.

Implementation

This PR includes a markdown file outlining what information the frontend needs in order to display graphical P&ID data.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • This change requires a documentation update

How Has This Been Tested?

  • Tested that the JSON structure is legal by creating a JSON file in WebStorm.
  • Checked that it's possible to apply styled-component styles received from a JSON file.

Copy link
Contributor

@daghovland daghovland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dette tror jeg er en bra plan!

Copy link
Contributor

@markus-ap markus-ap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good plan well documented!

@NoraKri NoraKri merged commit 7aaedd3 into main Dec 5, 2024
1 check passed
@NoraKri NoraKri deleted the story/203007-graphical-format branch December 5, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants