Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Release Candidate v2.0.2 #153

Merged
merged 36 commits into from
Dec 20, 2024
Merged

Task: Release Candidate v2.0.2 #153

merged 36 commits into from
Dec 20, 2024

Conversation

jonrandahl
Copy link
Contributor

This PR brings all of the alerting improvements from dev onto the preprod instance

bogdanadrianmarc and others added 30 commits December 11, 2024 13:55
- ensures that logging always happens with the appropriate severity depending on the exception status
- reduces the types of errors that can trigger a an error metric and therefore a notification in slack (e.g. :bad_request is set at WARN level and therefore not alerted on, whereas :internal_server_error is set at ERROR level and does trigger alerts
also align the operands of a condition in an `unless` statement spanning multiple lines
prevents unknown method errors if nil
- `Metrics/MethodLength`
- `Metrics/CyclomaticComplexity`
now triggers `api_service_exception` metric on error
update to use `Rails.public_path` alongside ending the path with `.html` to be sure
Emits logs with specific message and error to help pinpoint
also restores block to resolve unexpected token tRPAREN error as well as sets Time.now.year to Time.current.year to ensure zone is incorporated in calculations
@jonrandahl jonrandahl self-assigned this Dec 20, 2024
@jonrandahl jonrandahl changed the title Task: Release Candidate v2.0.1 Task: Release Candidate v2.0.2 Dec 20, 2024
@jonrandahl jonrandahl merged commit 98d3802 into preprod Dec 20, 2024
2 checks passed
@jonrandahl jonrandahl deleted the task/rc-2.0.1 branch December 20, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants