Reducing log noise and other current issues #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensures that logging always happens with the appropriate severity depending on the exception status - reduces the types of errors that can trigger a an error metric and therefore a notification in slack (e.g. :bad_request is set at WARN level and therefore not alerted on, whereas :internal_server_error is set at ERROR level and does trigger alerts
also align the operands of a condition in an `unless` statement spanning multiple lines
prevents unknown method errors if nil
- `Metrics/MethodLength` - `Metrics/CyclomaticComplexity`
now triggers `api_service_exception` metric on error
update to use `Rails.public_path` alongside ending the path with `.html` to be sure
Emits logs with specific message and error to help pinpoint
also restores block to resolve unexpected token tRPAREN error as well as sets Time.now.year to Time.current.year to ensure zone is incorporated in calculations
as otherwise ruby throws `unexpected token tRPAREN` error
jonrandahl
requested review from
bogdanadrianmarc,
DanielCouzens and
joescottdave
and removed request for
DanielCouzens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While containing the primary improvements for the #149 ticket itself, this also contains updating the error template path to use Rails.public_path as well as contain the html extension to ensure the correct template is rendered alongside a myriad of tweaks to ensure safe navigation to access variable value, assigning to a default value to prevent errors in the application. or simply improving the build process via the makefile.
This also includes multitude of Rubocop fixes or disabling of rules where applicable.