Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike/internal app error fix #151

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Spike/internal app error fix #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4e192a
Fixed undefined var or method in ReportManagerApi
bogdanadrianmarc Dec 11, 2024
3db7ac3
Bumped app version
bogdanadrianmarc Dec 11, 2024
6df653c
Added changelog entry
bogdanadrianmarc Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Standard Reports UI: change log

## 2.0.1 - 2024-12

- (Bogdan) Fixed a bug that was causing an internal application error in `ReportManagerApi`

## 2.0.0 - 2024-12

- (Bogdan) Updated all gems by regenerating `Gemfile.lock`
Expand Down
2 changes: 1 addition & 1 deletion app/lib/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
module Version
MAJOR = 2
MINOR = 0
PATCH = 0
PATCH = 1
SUFFIX = nil
VERSION = "#{MAJOR}.#{MINOR}.#{PATCH}#{SUFFIX && ".#{SUFFIX}"}"
end
2 changes: 1 addition & 1 deletion app/services/report_manager_api.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ def log_api_response(response, start_time, url: nil, status: nil, message: '')

case response_status
when 500..599
log_fields[:message] = env['action_dispatch.exception']
log_fields[:message] = response.env['action_dispatch.exception']
Rails.logger.error(JSON.generate(log_fields))
when 400..499
Rails.logger.warn(JSON.generate(log_fields))
Expand Down