Reducing log noise and other current issues #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added message, status, and type arguments to be logged
- ensures that logging always happens with the appropriate severity depending on the exception status - reduces the types of errors that can trigger a an error metric and therefore a notification in slack (e.g. :bad_request is set at WARN level and therefore not alerted on, whereas :internal_server_error is set at ERROR level and does trigger alerts
update to use `Rails.public_path` alongside ending the path with `.html` to be sure
jonrandahl
requested review from
bogdanadrianmarc,
DanielCouzens and
joescottdave
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While containing the primary improvements for the #149 ticket itself, this also contains updates specific to the following comment:
This has been resolved by updating the error template path to use
Rails.public_pathas well as contain thehtmlextension to ensure the correct template is renderedChanges also includes the following:
SENTRY_API_KEYenv var toentrypoint.shin the docker buildsearch_controllermessage,status, andtypearguments to be logged by thejson_rails_loggergem for respective error responses in thesearch_controller