Patch: Backport noise reduction #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpty-for-integer Task: Release Candidate v1.7.9
Release v1.7.8
Release v1.7.9 to Preprod
Release v1.7.9 to Production
Wrapped the Internal Error Instrumentation in an `unless` block to ensure the application does not report internal errors to the Prometheus metrics when the error is a 404 or 422 thereby reducing the noise in the Slack alerts channel
Added `RoutingError` and `MissingTemplate` to the list of exceptions to be caught by the `render_error_page` helper method in the `search_controller`; also configured the helper to display the actual rails stack trace in development mode
Added the `log_error` helper to the `render_error_page` helper method in the `search_controller` to apply the appropriate log level based on the status code
Removed `assets` call from `local` target alongside adding the ability to pass in the `API_SERVICE_URL` for local development; as well as removed unavailable `:unit` flag from `test` target and cleaned the echoed test message
from 1.7.9 ~> 1.7.10
Hotfix: Logging improvements
joescottdave
approved these changes
Oct 9, 2024
as `RoutingError` and `MissingTemplate` errors are caught by the application and not passed to the controller.
This was preventing all gems to be installed locally
As copy had changed in the code, the test required updating
As there are no system tests this command was not needed
from 1.7.10 ~> 1.7.11
joescottdave
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the production hotfix for log noise reduction back onto the dev branch