Issue/245 undefined method empty for integer #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2024-09 Security Patch
Sanitises a string for HTML output (using Rails' built-in sanitizer)
Remove any non-allowlisted parameters, or params with empty values (e.g. empty strings, empty arrays)
Sanitises the supplied input for HTML output using Rails' built-in sanitizer helper
v1.7.6 ~> 1.7.7
`ActionController::Base.helpers.sanitize(val)` ~> `Rails::Html::FullSanitizer.new.sanitize(val)`
now checks for date type and only sanitises strings for `search_term.value`
Task: Release Candidate v1.7.7
updated the type check for the current search terms to only sanitise strings and pass other types, i.e. Date, Integer, as is.
Due to the manner Rails swallows the stack trace if presenting a custom error template early the ticket issue was hard to determine while stepping through the current codebase; now standard Rails error templates will be used in production and test environments
updated the type check for the current search terms to only sanitise strings and pass other types, i.e. Date, Integer, as is.
…empty-for-integer
bogdanadrianmarc
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the update from ticket #245 back onto the development instance