Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Release Candidate v1.7.9 #246

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

jonrandahl
Copy link
Contributor

This PR resolves the search issue highlighted in ticket #245

updated the type check for the current search terms to only sanitise strings and pass other types, i.e. Date, Integer, as is.
Due to the manner Rails swallows the stack trace if presenting a custom error template early the ticket issue was hard to determine while stepping through the current codebase; now standard Rails error templates will be used in production and test environments
Copy link
Contributor

@bogdanadrianmarc bogdanadrianmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonrandahl jonrandahl merged commit 6c08702 into preprod Sep 16, 2024
2 checks passed
@jonrandahl jonrandahl deleted the issue/245-undefined-method-empty-for-integer branch September 16, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants