-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.7.6 #214
Merged
Merged
Release v1.7.6 #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specifically rescues from `::BadRequest` and `::RecordNotFound` instead of relying on catching a routing error; also added the ability to render a 400 error in the correct template
these were originally created at the project start and are not used in any manner for the error control or presentation.
status doesn't exist in this way on the StandardError Exception
minor adjustments to improve local development
lock rubygems-update to version that supports ruby 2.6.6
RubyGems version (3.0.3) has a bug that prevents `required_ruby_version` from working for Bundler. Any scripts that use `gem install bundler` will break as soon as Bundler drops support for your Ruby version. Please upgrade RubyGems to avoid future breakage and silence this warning by running `gem update --system 3.2.3`
…template Resolve missing error template files
Removed unknown constants from application_controller.rb as well as reordered rescues to ensure specific errors are not caught early by the generic `Exception` rescue
fix: resolve app failures
added the ActionView::MissingTemplate rescue
…te-error Resolve Missing Template 404
now returns the error status as human readable plain string which does not require a specific template
…te-error Resolve Missing Template error
Release Candidate v.1.7.6
der
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the current changes listed below onto the production branch:
Additional Changes