Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.7.6 #214

Merged
merged 23 commits into from
Mar 8, 2024
Merged

Release v1.7.6 #214

merged 23 commits into from
Mar 8, 2024

Conversation

jonrandahl
Copy link
Contributor

@jonrandahl jonrandahl commented Mar 8, 2024

This PR brings the current changes listed below onto the production branch:

  • Temporarily disabled deployment to production while still allowing build to complete
  • Added the rendering of missing templates as plain human readable strings
  • Added the ability to render a 400 error in the correct template
  • Added a 403 error template
  • Removed erroneous method from StandardError rescue
  • Updated .gitignore to ensure expected files are included!

Additional Changes

  • Removed erroneous error templates
  • Updated Makefile targets
  • Resolved build error in docker container
  • Minor code reorganisation for improved readability

der and others added 23 commits November 27, 2023 17:46
specifically rescues from `::BadRequest` and `::RecordNotFound` instead of relying on catching a routing error; also added the ability to render a 400 error in the correct template
these were originally created at the project start and are not used in any manner for the error control or presentation.
status doesn't exist in this way on the StandardError Exception
minor adjustments to improve local development
lock rubygems-update to version that supports ruby 2.6.6
RubyGems version (3.0.3) has a bug that prevents `required_ruby_version` from working for Bundler. Any scripts that use `gem install bundler` will break as soon as Bundler drops support for your Ruby version. Please upgrade RubyGems to avoid future breakage and silence this warning by running `gem update --system 3.2.3`
…template

Resolve missing error template files
Removed unknown constants from application_controller.rb as well as reordered rescues to ensure specific errors are not caught early by the generic `Exception` rescue
added the ActionView::MissingTemplate rescue
now returns the error status as human readable plain string which does not require a specific template
@jonrandahl jonrandahl self-assigned this Mar 8, 2024
@jonrandahl jonrandahl marked this pull request as ready for review March 8, 2024 16:22
Copy link
Member

@der der left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonrandahl jonrandahl merged commit 6229aa3 into prod Mar 8, 2024
2 checks passed
@jonrandahl jonrandahl deleted the task/release-v1.7.6 branch March 8, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants