-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.12 Support #73
Conversation
e54476b
to
665439d
Compare
Uses a fix for actions/checkout mentioned in actions/checkout#1809
- name: Python 3.5 Fix | ||
if: ${{ matrix.python == '3.5' }} | ||
run: | | ||
curl https://bootstrap.pypa.io/pip/3.5/get-pip.py | python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that is what happened... Using curl
seems straightforward enough for a CI job.
For future reference, I would be fine with dropping the py3.5 builds at this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment but otherwise all looks good
Bumps versions of
setuptools_dso
andepicscorelibs
to alpha releases with Python 3.12 support.