-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to make participant data anonymous #1453
base: main
Are you sure you want to change the base?
Conversation
felixrindt
commented
Dec 22, 2024
•
edited
Loading
edited
- user docs
- translate
- frontend
- model
- api
- tests
{% if participation.show_participant_data %} | ||
{{ participation.participant }} | ||
{% else %} | ||
{% translate "Anonymous" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use a more friendly term, IMO its weird to see that you will share the shift with "Anonymous". One idea would be to disclose the relevant qualifications (reads as: I will share the KTW with another RS). If we don't want to expose this as well we should at least use a more friendly term
{{ participation.participant }} | ||
{% else %} | ||
<i class="fas fa-user-secret px-1"></i> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again not sure if that is the best visualization for your fellow volunteers
could also look a bit weird because the badges are suddenly very short?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the wording and icon choice aren't optimal. Lets discuss this in a call?!
@jeriox Do you think we should show all participant info if the viewing user has view_userprofile permissions? In the API they would be allowed to view all participations of all users. I don't like the inconsistency... |
yeah I think so. viewing the userprofile includes viewing working hours, which in turn reveals participations. so they should be visible on the event page as well. |