Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to make participant data anonymous #1453

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

felixrindt
Copy link
Member

@felixrindt felixrindt commented Dec 22, 2024

  • user docs
  • translate
  • frontend
  • model
  • api
    • tests

@felixrindt felixrindt added the [C] feature New feature or request label Dec 22, 2024
@coveralls
Copy link

coveralls commented Dec 22, 2024

Coverage Status

coverage: 83.899% (+0.03%) from 83.874%
when pulling 0ddcdd6 on hide-participant-data
into 9e8f868 on main.

@felixrindt felixrindt marked this pull request as ready for review December 22, 2024 11:27
@felixrindt felixrindt requested a review from jeriox December 22, 2024 11:28
@felixrindt felixrindt changed the title show-participant-data and API Option to make participant data anonymous Dec 22, 2024
{% if participation.show_participant_data %}
{{ participation.participant }}
{% else %}
{% translate "Anonymous" %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use a more friendly term, IMO its weird to see that you will share the shift with "Anonymous". One idea would be to disclose the relevant qualifications (reads as: I will share the KTW with another RS). If we don't want to expose this as well we should at least use a more friendly term

{{ participation.participant }}
{% else %}
<i class="fas fa-user-secret px-1"></i>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again not sure if that is the best visualization for your fellow volunteers
could also look a bit weird because the badges are suddenly very short?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the wording and icon choice aren't optimal. Lets discuss this in a call?!

@felixrindt
Copy link
Member Author

@jeriox Do you think we should show all participant info if the viewing user has view_userprofile permissions? In the API they would be allowed to view all participations of all users. I don't like the inconsistency...

@jeriox
Copy link
Contributor

jeriox commented Dec 23, 2024

@jeriox Do you think we should show all participant info if the viewing user has view_userprofile permissions? In the API they would be allowed to view all participations of all users. I don't like the inconsistency...

yeah I think so. viewing the userprofile includes viewing working hours, which in turn reveals participations. so they should be visible on the event page as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants