Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add responsible indicator #1452

Merged
merged 10 commits into from
Jan 5, 2025
Merged

add responsible indicator #1452

merged 10 commits into from
Jan 5, 2025

Conversation

felixrindt
Copy link
Member

@felixrindt felixrindt commented Dec 18, 2024 •
edited
Loading

when testing the bulk actions, it was helpful to have some kind of indicator in the event list list to see what events I am responsible for.
This is what I came up with in a few minutes of tinkering with it.

image

closes #1258
closes #874

@felixrindt felixrindt added the [C] enhancement Changes to an existing feature making it better label Dec 18, 2024
@felixrindt felixrindt requested a review from jeriox December 18, 2024 12:08
@coveralls
Copy link

coveralls commented Dec 18, 2024 •
edited
Loading

Coverage Status

coverage: 83.874% (-0.006%) from 83.88%
when pulling c01ad62 on responsible-indicator
into 92009e8 on main.

@jeriox
Copy link
Contributor

jeriox commented Dec 18, 2024

cool idea. first thoughts:

  • I'm not sure if the icon placement is perfect, this makes the title wrap even quicker
  • not sure if the crown is the best icon choice/super intuitive
  • we should also think about this in combination with Display event visibility #874, maybe we can even come up with some kind of combined indicator?

@felixrindt
Copy link
Member Author

image

I got the query working :)

@felixrindt felixrindt force-pushed the responsible-indicator branch from 5d82f95 to 40014c3 Compare December 23, 2024 19:25
jeriox
jeriox reviewed Dec 23, 2024
View reviewed changes
ephios/core/views/event.py Outdated Show resolved Hide resolved
@felixrindt felixrindt force-pushed the responsible-indicator branch from 759ee96 to f39373b Compare January 3, 2025 19:28
@felixrindt felixrindt mentioned this pull request Jan 5, 2025
Closed
@felixrindt felixrindt requested a review from jeriox January 5, 2025 13:57
@felixrindt felixrindt merged commit 8707358 into main Jan 5, 2025
15 checks passed
@felixrindt felixrindt deleted the responsible-indicator branch January 5, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeriox jeriox jeriox approved these changes

Assignees
No one assigned
Labels
[C] enhancement Changes to an existing feature making it better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Also show responsible groups in the "visible for" list Display event visibility
3 participants
@felixrindt @coveralls @jeriox