Prepare SQL from file on application start. New function for using pr… #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you can make a tag after merging, it would be amazing. |
Closed
Conflicts: src/pgapp.erl src/pgapp_worker.erl
|
this could be merged after epgsql/epgsql#92 |
|
@davidw @seriyps @fishcakez once you have merged epgsql/epgsql#92, can you please check this PR? It prepares sql statements from file on start of pgapp, which later could be used in new epgsql:prepared_query function. |
| @@ -77,16 +99,29 @@ with_transaction(PoolName, Fun, Timeout) -> | |||
| {transaction, Fun}, Timeout) | |||
| end, Timeout). | |||
|
|
|||
|
|
|||
| -include_lib("epgsql/include/epgsql.hrl"). | |||
| -include("worker_args.hrl"). | |||
There was a problem hiding this comment.
Includes should be somewhere in module's header (near defines).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepared SQL functionality.
It introduces new setting to a pool, but is backward-compatible.