Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake and README to work with SVA/RBDyn/mc_rbdyn_urdf master #61

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

gergondet
Copy link
Contributor

This PR updates the CMake script and the instruction to build the stack with up-to-date SpaceVecAlg, RBDyn and mc_rbdyn_urdf

Depending on how things go with jrl-umi3218/SpaceVecAlg#29 we can amend the instructions

@costashatz
Copy link
Collaborator

@gergondet sorry for the late reply! Many things going on!

This looks perfect. @nash169 @walidAmanhoud @fkhadivar can you make sure that this compiles on EPFL machines with latest jrl-umi3218 libraries and the lib runs ok for iiwa/ROS? If this causes no issues with our code and iiwa can be controlled/compiled smoothly, this is OK with me.

@domire8
Copy link

domire8 commented Oct 13, 2021

@gergondet @costashatz This is fine overall, I compiled the code and run some of the robot control in the lab and it works. I get one warning that is new though:

[rospack] Warning: error while crawling /home/lorenzo/iiwa_test_ws/src/mc_rbdyn_urdf/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests: boost::filesystem::status: Too many levels of symbolic links: "/home/lorenzo/iiwa_test_ws/src/mc_rbdyn_urdf/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake";  Too many levels of symbolic links
[rospack] Warning: error while crawling /home/lorenzo/iiwa_test_ws/src/mc_rbdyn_urdf/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests: boost::filesystem::status: Too many levels of symbolic links: "/home/lorenzo/iiwa_test_ws/src/mc_rbdyn_urdf/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake/_unittests/cmake"

This might come from this PR and can be tested without the connection to the robot, so maybe try to recreate and resolve. Also, it might be nice to add a small instruction line before catkin_make that the user should do a sudo ldconfig.
Cheers

@costashatz
Copy link
Collaborator

I get one warning that is new though:

@gergondet can you solve this? Afterwards, I'll merge this.

Also, it might be nice to add a small instruction line before catkin_make that the user should do a sudo ldconfig

I'll do a different PR for this. Thanks.

@gergondet
Copy link
Contributor Author

Hi @domire8 @costashatz

Sorry for the late reply.

I think the issue should go away if you run git submodule update in the mc_rbdyn_urdf folder (this is an issue with our cmake submodule that has been fixed a while ago)

Thanks for trying it out

@domire8
Copy link

domire8 commented Oct 21, 2021

Hi @domire8 @costashatz

Sorry for the late reply.

I think the issue should go away if you run git submodule update in the mc_rbdyn_urdf folder (this is an issue with our cmake submodule that has been fixed a while ago)

Thanks for trying it out

That does not solve the issue. But that's also just a warning, not an error I guess.

@gergondet
Copy link
Contributor Author

@domire8 did you update mc_rbdyn_urdf to the latest version available at jrl-umi3218/mc_rbdyn_urdf ?

@gergondet
Copy link
Contributor Author

@domire8 did you update mc_rbdyn_urdf to the latest version available at jrl-umi3218/mc_rbdyn_urdf ?

Nevermind, I just realized I had looked at the wrong folder previously, I will update the submodule in jrl-umi3218/mc_rbdyn_urdf and that should do the trick

@costashatz
Copy link
Collaborator

Nevermind, I just realized I had looked at the wrong folder previously, I will update the submodule in jrl-umi3218/mc_rbdyn_urdf and that should do the trick

Great! Let us know when you are done to check..

@gergondet
Copy link
Contributor Author

Great! Let us know when you are done to check..

It should be ok on the most recent version.

@costashatz
Copy link
Collaborator

@domire8 is the fix working now? Thanks!

Copy link

@domire8 domire8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry guys, lost track of that but I tested it now and it works fine, without the CMake warning. Good to go! 🚀

@costashatz
Copy link
Collaborator

@domire8 @gergondet thanks a lot! Merging this!

@costashatz costashatz merged commit 98fb0fe into epfl-lasa:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants