Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect import statement when both overriden_models and separate_models options are used #756

Closed
wants to merge 1 commit into from

Conversation

monoblaine
Copy link

@monoblaine monoblaine commented Jun 14, 2024

First of all, I want to say thank you for this great project which I've only been experimenting with for two days and the DevEx it provides is almost flawless. In my case, some field of type Map<String, List<SomeDto>> inside a model was created as Map<String, dynamic>, but thanks to the overriden_models option I was able to handle it with a custom model class. I was also using the separate_models option and that led to some hard-coded import 'overriden_models.dart'; lines inside the *.swagger.dart files, which I think is a bug. This PR replaces the hard-coded import statement with the value of importUrl field from options.overridenModels.

Fixes #745

@Vovanella95
Copy link
Collaborator

This change already in master

@Vovanella95
Copy link
Collaborator

@monoblaine sorry I don't have time to support this package. Thanks for contribution! Feel free to create a Pull requests. I will upload changes to pub.dev regularry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Error when both overriden_models and separate_models are used
2 participants