336 build install fail #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be referenced with a normalized path (not sure if this was the solution but the xml file is now getting included in to the tarball). - Updated `download_url` to point to the GitHub project page as DisplayCAL.net is not getting updated with new files.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that I was generating the tarball in MacOS and the section related adding the
net.displaycal.DisplayCAL.appdata.xmlfile was not working when run through MacOS. Fixed by moving that code to an os independent path. The generated tarball is working find in MacOS and generating a new tarball from Linux is working too. Didn't have time to test the tarball generated with MacOS on Linux, but I reckon that it is going to run okay.