Fix error DisplayCAL is already installed #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix ERROR: venv is up-to-date change Makefile "venv" build target to "environment" build target to avoid collision with possible existing PyCharm venv folder - fix ERROR: DisplayCAL is already installed change Makefile "install" build target to use --force-reinstall by default since 'make build' will already list DisplayCAL as installed using pip
|
Hmm the correct solution would be to add .PHONY: venv
venv:
python3 -m venv $(VIRTUALENV_DIR); \
source ./$(VIRTUALENV_DIR)/bin/activate; \
pip install -r requirements.txt; \
pip install -r requirements-dev.txt; |
|
Updated the PR to use .PHONY |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ERROR: venv is up-to-date
If the user has an existing
venvfolder in the main project directory,make buildwill fail sincemake venvwill exit with the message that the build target venv is up-to-date. This situation occurs when the popular PyCharm IDE is used with the project that creates a venv folder for its environment. Renaming the build target avoids this collision.Fix ERROR: DisplayCAL is already installed
After
make buildpip will already list DisplayCAL as an installed packaged which can be verified withpip list | grep DisplayCALand therefor not install DisplayCAL despite the fact that.venv/bin/displaycaldoesn't exist. Adding --force-reinstall will avoid this error.