Adding fixes for ghcr.io #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The github test case is in tests/githubtest/. Just set a GITHUB_TOKEN to a token from https://github.com/settings/tokens/new?scopes=write:packages and run test.sh |
vehagn
approved these changes
Jan 16, 2024
| return resolve(headOk(res.headers.location, headers, allowInsecure, optimisticCheck, ++depth)); | ||
| } | ||
| // Unauthorized | ||
| // Possibly related to https://gitlab.com/gitlab-org/gitlab/-/issues/23132 |
There was a problem hiding this comment.
I can take a look at this. I managed to push to GitLab after getting a jwt token by running
SCOPE="repository:${CI_PROJECT_NAMESPACE}/${CI_PROJECT_NAME}:pull,push"
AUTH_URL="${CI_SERVER_URL}/jwt/auth?service=container_registry&scope=${SCOPE}"
TOKEN=$(curl -sL --user "${CI_REGISTRY_USER}:${CI_REGISTRY_PASSWORD}" "${AUTH_URL}" | sed 's/.*"token":"\{0,1\}\([^,"]*\)"\{0,1\}.*/\1/')
yarn containerify --folder . --toRegistry "https://${CI_REGISTRY}/v2/${CI_PROJECT_NAMESPACE}" --toImage "${CI_PROJECT_NAME}:latest" --toToken $TOKEN
I assume we can run some checks on the container registry URL to determine if we should fetch this token or not.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems helpful: https://distribution.github.io/distribution/spec/api/#digest-parameter
Had to change some of the content-types to reflect that (e.g. use application/octet-stream for non-manifest files). Seems to still work with the docker registry, but should be tested also with OpenShift or similar.