Skip to content

Commit

Permalink
Increase hard shutdown timeout to 30 seconds (#1193)
Browse files Browse the repository at this point in the history
This is inline with the default connection connect timeout period in 30 seconds. For well behaved clients with short response latencies, this should be a no-op as we will end prematurely once the pool is idle. This does allow for clients with high latencies a long enough time to resolve gracefully.

Signed-off-by: Tom Zhang <[email protected]>
  • Loading branch information
tomjzzhang authored Jul 10, 2024
1 parent 8727081 commit 0f8478e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion source/client/benchmark_client_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ void BenchmarkClientHttpImpl::terminate() {
ENVOY_LOG(info, "Wait for the connection pool drain timed out, proceeding to hard shutdown.");
dispatcher_.exit();
});
drain_timer_->enableTimer(5s);
drain_timer_->enableTimer(30s);
dispatcher_.run(Envoy::Event::Dispatcher::RunType::RunUntilExit);
}
}
Expand Down

0 comments on commit 0f8478e

Please sign in to comment.