Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added JSONPatch example for modifying Bootstrap config using the EnvoyProxy resource #4772

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

alrai
Copy link
Contributor

@alrai alrai commented Nov 24, 2024

What type of PR is this?

What this PR does / why we need it:
Enhances the existing docs.

Which issue(s) this PR fixes:
Fixes #4742

Release Notes: No

@alrai alrai requested a review from a team as a code owner November 24, 2024 13:11
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.60%. Comparing base (71c0b54) to head (4923e58).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4772      +/-   ##
==========================================
- Coverage   65.61%   65.60%   -0.02%     
==========================================
  Files         211      211              
  Lines       31961    31961              
==========================================
- Hits        20972    20968       -4     
- Misses       9750     9753       +3     
- Partials     1239     1240       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

zhaohuabing

This comment was marked as resolved.

@alrai
Copy link
Contributor Author

alrai commented Nov 25, 2024

@zhaohuabing In this PR I modified the 3 files including the one you mentioned:

site/content/en/docs/tasks/operations/customize-envoyproxy.md
site/content/en/latest/tasks/operations/customize-envoyproxy.md
site/content/en/v1.2/tasks/operations/customize-envoyproxy.md

@zhaohuabing
Copy link
Member

@zhaohuabing In this PR I modified the 3 files including the one you mentioned:
Sorry that I missed that. LGTM thanks!

@zirain zirain merged commit 05aa9fd into envoyproxy:main Nov 25, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JSONPatch example for modifying Bootstrap config using the EnvoyProxy resource
3 participants