bugfix: optimize routes status unnecessary deepcopy. #4527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4527 +/- ##
==========================================
+ Coverage 65.72% 65.75% +0.03%
==========================================
Files 211 211
Lines 31669 31623 -46
==========================================
- Hits 20813 20795 -18
+ Misses 9656 9627 -29
- Partials 1200 1201 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: qicz <[email protected]>
|
/retest |
arkodg
reviewed
Oct 25, 2024
| @@ -66,16 +66,20 @@ func (r *gatewayAPIReconciler) subscribeAndUpdateStatus(ctx context.Context, ext | |||
| r.statusUpdater.Send(Update{ | |||
| NamespacedName: key, | |||
| Resource: new(gwapiv1.HTTPRoute), | |||
| Mutator: MutatorFunc(func(obj client.Object) client.Object { | |||
| Mutator: MutatorFunc(func(obj client.Object) bool { | |||
There was a problem hiding this comment.
the API is for mutating obects but is now returning a bool ? this doesnt seem right
There was a problem hiding this comment.
changed this api to boolean
There was a problem hiding this comment.
What is the new definition for the mutator function
|
can you the memory diff before-after? |
I think we should deal this after #4498 (comment) That's comparable with the same way |
qicz
commented
Oct 26, 2024
| } | ||
|
|
||
| // MutatorFunc is a function adaptor for Mutators. | ||
| type MutatorFunc func(client.Object) client.Object | ||
| type MutatorFunc func(client.Object) bool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part Fixes #4516
Release Notes: Yes/No