Revert "dynamic_modules: adds dynamic metadata callbakcs (#37860)" #37896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…37860)" This reverts commit 0e9be24. Signed-off-by: Ryan Northey <[email protected]>
|
not sure how this got past ci - but looks like a bad merge cc @mathetake |
ravenblackx
approved these changes
Jan 6, 2025
mathetake
added a commit
to mathetake/envoy
that referenced
this pull request
Jan 7, 2025
…oyproxy#37860)" (envoyproxy#37896)" This reverts commit 1172429. Signed-off-by: Takeshi Yoneda <[email protected]>
mattklein123
pushed a commit
that referenced
this pull request
Jan 7, 2025
…7905) #37860 was reverted in #37896 because of the slight build fix after #37880. This fixes the original commit. --------- Signed-off-by: Takeshi Yoneda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0e9be24.