Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Reader example code to wait for input #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tlk
Copy link

@tlk tlk commented Dec 14, 2019

README.md has examples on how to use DataReader, JSONReader and URLParametersReader and the instructions says that the example code will wait for input to be read.

However, as explained by @fangpenlin in #18 (comment) the current example code

(..) is meant for returning simple data without any async operation, that's why it won't wait for reading POST data body or any other HTTP body data

I suggest updating the example code to wait for input and to handle the case of no input at all (see
envoy/Embassy#64).

@tlk
Copy link
Author

tlk commented Dec 14, 2019

Refs #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant