Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply php dev best practices #248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Apply php dev best practices #248

wants to merge 1 commit into from

Conversation

EHJ-52n
Copy link
Contributor

@EHJ-52n EHJ-52n commented Nov 11, 2015

  • Replace short open tags with long version
  • Remove closing tag at end of files

Fixes #110

http://php.net/manual/en/language.basic-syntax.phptags.php

@EHJ-52n
Apply php dev best practices
de88fe0 
- Replace short open tags with long version
- Remove closing tag at end of files
@EHJ-52n
Copy link
Contributor Author

EHJ-52n commented Nov 11, 2015

You should apply this PR somehow to the dev branch, too.

@matthesrieke
Copy link
Member

urgs :) other way would have been easier

@EHJ-52n
Copy link
Contributor Author

EHJ-52n commented Nov 11, 2015

You are right. 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthesrieke matthesrieke

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EHJ-52n @matthesrieke