Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RYYGate decomposition bug #320

Merged

Conversation

yoshioka1128
Copy link

@yoshioka1128 yoshioka1128 commented Aug 6, 2024

Description

This pull request addresses a bug in the implementation of the RYY gate within the RYYGateMap class, located in src/openqaoa-core/openqaoa/qaoa_components/ansatz_constructor/gatemap.py. The issue was causing incorrect gate behavior, affecting the accuracy of quantum circuit simulations running in the cloud environment.

Changes:

Corrected the mathematical decomposition of the RYY gate.

Bug Description:

The previous implementation of the RYY gate decomposition had an error in the rotation parameters, which led to unexpected results in our quantum algorithms. This fix corrects the parameters to align with the standard definition of the RYY gate.

Impact:

This fix is critical for any application relying on the accurate implementation of the RYY gate. It ensures that our quantum algorithms perform as expected and that the results are reliable.

Please review the changes and let me know if there are any questions or further modifications needed.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code and used numpy-style docstrings
  • I have made corresponding updates to the documentation.
  • My changes generate no new warnings
  • I have added/updated tests to make sure bugfix/feature works.
  • New and existing unit tests pass locally with my changes.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@yoshioka1128 yoshioka1128 force-pushed the bugfix/ryygate-decomposition branch from 737fcf9 to 5b19226 Compare August 6, 2024 07:52
@yoshioka1128 yoshioka1128 force-pushed the bugfix/ryygate-decomposition branch from 5b19226 to 43f61ec Compare August 7, 2024 00:24
@vishal-ph vishal-ph merged commit c13c909 into entropicalabs:dev Aug 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants