Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev into main #298

Merged
merged 8 commits into from
Dec 20, 2023
Merged

Merge dev into main #298

merged 8 commits into from
Dec 20, 2023

Conversation

KilianPoirier
Copy link
Collaborator

Description

Checklist

  • I have performed a self-review of my code.
  • My changes generate no new warnings
  • I have added/updated tests to make sure bugfix/feature works.
  • New and existing unit tests pass locally with my changes.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Modified the unit test associated with this.

@KilianPoirier KilianPoirier marked this pull request as ready for review December 20, 2023 13:32
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (3c76547) 87.70% compared to head (ff7363f) 87.69%.
Report is 3 commits behind head on main.

Files Patch % Lines
src/openqaoa-core/openqaoa/problems/bpsp.py 57.14% 9 Missing ⚠️
...enqaoa-qiskit/tests/test_circuit_routing_qiskit.py 0.00% 3 Missing ⚠️
src/openqaoa-qiskit/tests/test_qpu_qiskit.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   87.70%   87.69%   -0.02%     
==========================================
  Files         153      153              
  Lines       16501    16501              
==========================================
- Hits        14473    14470       -3     
- Misses       2028     2031       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KilianPoirier KilianPoirier merged commit 2cc9ea0 into main Dec 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant