Filter drilldown for mixed column #11694
Open
+31
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Storybook is successfully deployed!📊 Dashboard:
|
marthasharkey
changed the title
marthasharkey
requested review from
Frizi,
farmaazon,
vitvakatu,
kazcw and
AdRiley
as code owners
kazcw
reviewed
Nov 28, 2024
| } | ||
| if (columnType === 'Date_Time') { | ||
| return (item: string) => Ast.parseExpression(`(Date_Time.parse '${item}')`)! | ||
| } | ||
| if (columnType == 'Mixed') { | ||
| return (item: string, module: Ast.MutableModule) => { |
There was a problem hiding this comment.
This case is complex. I would:
- Divide it into two steps--first call a function that categorizes the data, then transform it according to category.
- Add unit tests for value categorization.
| } | ||
| if (columnType === 'Time') { | ||
| return createDateTimePattern('(Time_Of_Day.new __ __ __ __ __ __)', 6) | ||
| return (item: string) => Ast.parseExpression(`(Time_Of_Day.parse '${item}')`)! |
There was a problem hiding this comment.
This would break if the input contains ', or any character that is special inside an Enso interpolated string. Maybe AG-Grid would never provide such data, but we don't need to rely on that--TextLiteral.new handles escaping. In general, Ast.parseExpression is for when we have an arbitrary input and don't have any expectations about the shape of the output; when we know what kind of expression we want, using a constructor for the expected AST type or a Pattern avoids all kinds of syntax hazards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.