Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special treatment of PanicSentinel in CatchPanicNode #11167

Merged
merged 7 commits into from
Sep 26, 2024
Merged

Special treatment of PanicSentinel in CatchPanicNode #11167

merged 7 commits into from
Sep 26, 2024

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Sep 25, 2024 •
edited
Loading

Pull Request Description

Fixes #9402 by explicitly throwing PanicSentinel in CatchPanicNode. b89275b enhances CatchPanicNode to provide a special treatment of PanicSentinel and a85c561 adds some tests to verify the treatment.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
    Java,
  • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Sep 25, 2024
@JaroslavTulach JaroslavTulach self-assigned this Sep 25, 2024
@enso-bot enso-bot bot mentioned this pull request Sep 26, 2024
Closed
@JaroslavTulach JaroslavTulach added CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: Ready to merge This PR is eligible for automatic merge CI: Keep up to date Automatically update this PR to the latest develop. labels Sep 26, 2024
@mergify mergify bot merged commit 2fbd0aa into develop Sep 26, 2024
39 of 41 checks passed
@mergify mergify bot deleted the wip/db/9402-catch-panic-instrumented branch September 26, 2024 05:34
@enso-bot enso-bot bot mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4e6 4e6 4e6 approved these changes

@hubertp hubertp hubertp approved these changes

@Akirathan Akirathan Awaiting requested review from Akirathan Akirathan is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: Keep up to date Automatically update this PR to the latest develop. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It is impossible to catch Panics in the GUI
3 participants
@JaroslavTulach @hubertp @4e6