Add contract implementation for multiple contenthash records #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 18, 2020
cgewecke
reviewed
Feb 20, 2020
test/TestPublicResolver.js
Outdated
| @@ -453,6 +453,27 @@ contract('PublicResolver', function (accounts) { | |||
| null | |||
| ); | |||
| }); | |||
|
|
|||
| it('can set specific contenthash type', async () => { | |||
| await resolver.setContenthash(node, '0x0100000000000000000000000000000000000000000000000000000000000001', '0x01', {from: accounts[0]}); | |||
There was a problem hiding this comment.
@filips123 Apologies for looking over your shoulder, was reading the EIP and saw a note there about the unit tests. In truffle overloaded methods can be accessed via a methods key with their ABI sig.
An example from these tests is calling resolver.setAddr(node, accounts[1], {from: accounts[0]}) as:
resolvers/test/TestPublicResolver.js
Line 126 in 8958e4f
cgewecke
reviewed
Feb 26, 2020
Co-Authored-By: cgewecke <[email protected]>
|
@filips123 I think it may make sense to have 2 seperate resolvers. @Arachnid what do you think? |
|
Separate resolvers in what sense? Because I think it is easier to just have one. |
MicahZoltu
pushed a commit
to ethereum/EIPs
that referenced
this pull request
Nov 2, 2020
This adds my draft EIP for multiple contenthash records for ENS. Contract implementation is available in ensdomains/resolvers#30, and discussion should be in #2393.
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
This adds my draft EIP for multiple contenthash records for ENS. Contract implementation is available in ensdomains/resolvers#30, and discussion should be in ethereum#2393.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds implementation for multiple contenthash records on same ENS domain. It is part of new EIP (that extends the EIP 1577) that I'm writing.
Draft EIP is available in ethereum/EIPs#2520, and discussion should be in ethereum/EIPs#2393.